Phase 1.2: design diagnostics + 1.1.5 surfaced#2
Merged
Conversation
- diagnose_cbc_design() with MNL D-efficiency under uniform priors - QUALITY_GATE_MAX_LEVEL_IMBALANCE promoted to shared.py per Tenet 1 - Renames n_dominated -> n_duplicate alternatives (honest naming) - Production D-eff ~0.38 below 0.85 gate; sentinel test asserts the failure with docstring explaining the 1.1.5 fix path - 25+ new tests
CI's ruff format --check caught format drift that validate.sh missed (item #1 still only runs ruff check, per BACKLOG follow-up captured during Phase 1.1 rollout). Pure whitespace; no logic changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
path/to/file.py— what changed and whyLinked work
Validation checklist (Tenet 5)
main.py --checkpasseskai validate-taxonomypassesmain.py --boot-orderworksscripts/validate.shsummary:Documentation updated
Screenshots / log excerpts
N/A — no UI or user-facing output changes.
Risk + rollback plan
Diagnostic correctness change. The production sentinel test
intentionally asserts a gate failure (D-eff ~0.38 vs 0.85 threshold)
with a docstring explaining the path forward via BACKLOG 1.1.5.
No downstream consumers depend on the diagnostic output yet.
Revert is safe: restores the NotImplementedError stub.