Close validate.sh / CI lint gate parity gap#3
Merged
Conversation
validate.sh item #1 now runs ruff format --check in addition to ruff check, matching .github/workflows/lint.yml exactly. Adds tests/unit/test_validate_script_lint_parity.py as a regression guard against future drift in either direction. BACKLOG: closes 'validate.sh: extend item #1 to include ruff format check'
Gimpleberry
added a commit
that referenced
this pull request
Apr 29, 2026
Captures three patch-script-template improvements surfaced during the validate.sh / CI lint parity rollout (PR #3): 1. Sandbox must include kai.shared so Tenet 1 violations in generated Python files surface during pre-delivery QC. 2. Patch scripts that create Python files should run ruff format on them as a final edit step. 3. Parity-test pattern generalizes per CI workflow with a local mirror; defer meta-test until 2nd pair exists. All three are PRIORITY: triggered by next applicable patch, not by clock time.
15 tasks
Gimpleberry
added a commit
that referenced
this pull request
Apr 29, 2026
Captures three patch-script-template improvements surfaced during the validate.sh / CI lint parity rollout (PR #3): 1. Sandbox must include kai.shared so Tenet 1 violations in generated Python files surface during pre-delivery QC. 2. Patch scripts that create Python files should run ruff format on them as a final edit step. 3. Parity-test pattern generalizes per CI workflow with a local mirror; defer meta-test until 2nd pair exists. All three are PRIORITY: triggered by next applicable patch, not by clock time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate.sh item #1 now runs ruff format --check in addition to ruff check, matching .github/workflows/lint.yml exactly. Adds tests/unit/test_validate_script_lint_parity.py as a regression guard against future drift in either direction.
BACKLOG: closes 'validate.sh: extend item #1 to include ruff format check'
Summary
validate.sh item #1 now runs ruff format --check in addition to ruff check, matching .github/workflows/lint.yml exactly. Closes the local-vs-CI gate parity gap caught during Phase 1.1 and 1.2 rollouts. New tests/unit/test_validate_script_lint_parity.py regression-guards the invariant against future drift in either direction.
Changes
path/to/file.py— what changed and whyLinked work
validate.sh: extend item #1 to include ruff format check
Validation checklist (Tenet 5)
main.py --checkpasseskai validate-taxonomypassesmain.py --boot-orderworksscripts/validate.shsummary:Documentation updated
Screenshots / log excerpts
Risk + rollback plan
Tooling-only change. Pure git revert undoes it cleanly — no data, schema, or behavior changes. The local validation gate would briefly drift back from CI; that's the pre-patch state, and was survivable for the prior two PRs