fix: round cookie expiry field #3938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align with WebDriver BiDi spec, which requires the `expiry` to be integer. Addressing #3936
sadym-chromium
temporarily deployed
to
github-pages
GitHub Actions
Inactive
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 2029792 | Previous: 96a4ad3 | Ratio |
|---|---|---|---|
ubuntu-latest-new-headless-node:test_performance_screenshot |
163.78135681152344 ms |
164.784574508667 ms |
0.99 |
macos-latest-new-headless-cd:test_performance_screenshot |
3283.991575241089 ms |
3290.7699584960938 ms |
1.00 |
macos-latest-headful-cd:test_performance_screenshot |
3360.6587886810303 ms |
2286.2877368927 ms |
1.47 |
ubuntu-latest-old-headless-node:test_performance_screenshot |
268.6070919036865 ms |
264.61024284362793 ms |
1.02 |
macos-latest-old-headless-cd:test_performance_screenshot |
318.3086395263672 ms |
266.06154441833496 ms |
1.20 |
macos-latest-new-headless-node:test_performance_screenshot |
3141.3422107696533 ms |
3674.113988876343 ms |
0.85 |
macos-latest-old-headless-node:test_performance_screenshot |
261.78317070007324 ms |
268.19543838500977 ms |
0.98 |
ubuntu-latest-new-headless-cd:test_performance_screenshot |
174.49612617492676 ms |
174.54099655151367 ms |
1.00 |
ubuntu-latest-old-headless-cd:test_performance_screenshot |
268.47639083862305 ms |
278.2092571258545 ms |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
Lightning00Blade
approved these changes
Dec 9, 2025
Collaborator
Lightning00Blade
left a comment
Lightning00Blade
left a comment
There was a problem hiding this comment.
LGTM but lets add test if possible
Collaborator
Author
Oh, I missed the comment, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align with WebDriver BiDi spec, which requires the
expiryto be integer.Addressing #3936