Rename textStart==>start and textEnd==>end
#148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks Thomas! FYI I'm working on brushing up the spec in preparation for upstreaming to HTML - I wouldn't be surprised if there's some back and forth during the review into HTML so for your own sake you might want to wait a bit until the dust settles :) |
Member
Author
|
Oh, okay. That’s fair. I guess we can just accumulate changes in this PR nonetheless. |
tomayac
added a commit
to GoogleChrome/web.dev
that referenced
this pull request
May 31, 2023
… still pending
tomayac
added a commit
to GoogleChrome/web.dev
that referenced
this pull request
May 31, 2023
… still pending (#10112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following WICG/scroll-to-text-fragment#218, the present PR reflects these changes here.
Will this also need to be reflected in
FragmentDirective? There's currently no IDL for the actual item, but _de factoChrome exposes the names astextStartandtextEnd`.CC: @bokand