Detect text fragments in elements with 0 width/height and visible overflow #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was ignoring all elements that had a width or height of 0. But the contents of such elements can still be fully visible if the overflow is not set to hidden/clip etc. This is one of the issues reported in GoogleChromeLabs#164.
Member
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was ignoring all elements that had a width or height of 0. But the contents of such elements can still be fully visible if the overflow is not set to hidden/clip etc.
A simple example of such a case is something like this:
Because the paragraph is floating, the div will have a height of 0. But the paragraph is still visible and its text can be selected.
This is one of the issues that occurred in #164 (this comment).