fix: scope AWS config cache per region/profile #2104
+34
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Terraformer cached a single global aws.Config, so after importing global services (e.g., IAM) the same config was reused for regional passes.
When RDS ran next, it reused the global resolver and hit the wrong host instead of the region-specific rds.us-east-1.amazonaws.com, causing imports to fail.
Fix
Replace the singleton config pointer with a mutex-protected map keyed by region/profile/skip flags.
Build a fresh aws.Config for each unique key and cache it so the RDS pass resolves the correct regional endpoint while still reusing configs within the same scope.
Testing
gofmt providers/aws/aws_service.go
~/go/bin/go test ./providers/aws
Manual terraformer import aws --resources=rds --regions=us-east-1 (followed by other services) now succeeds against the standard RDS endpoint.