Skip to content

Conversation

@fishdan
Copy link

@fishdan fishdan commented Oct 10, 2025

Bug

Terraformer cached a single global aws.Config, so after importing global services (e.g., IAM) the same config was reused for regional passes.
When RDS ran next, it reused the global resolver and hit the wrong host instead of the region-specific rds.us-east-1.amazonaws.com, causing imports to fail.

Fix

Replace the singleton config pointer with a mutex-protected map keyed by region/profile/skip flags.
Build a fresh aws.Config for each unique key and cache it so the RDS pass resolves the correct regional endpoint while still reusing configs within the same scope.

Testing

gofmt providers/aws/aws_service.go
~/go/bin/go test ./providers/aws
Manual terraformer import aws --resources=rds --regions=us-east-1 (followed by other services) now succeeds against the standard RDS endpoint.

@google-cla
Copy link

google-cla bot commented Oct 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant