[WIP] Issue 281: Add placeholder 404.html to app/templates#282
Closed
tekd wants to merge 33 commits intoGovLab:masterfrom
Closed
[WIP] Issue 281: Add placeholder 404.html to app/templates#282tekd wants to merge 33 commits intoGovLab:masterfrom
tekd wants to merge 33 commits intoGovLab:masterfrom
Conversation
Contributor
|
Hey Denny! Sorry about the totally unhelpful 500 errors in the tests--we recently switched testing frameworks and one of the downsides is that the new one isn't showing the traceback of 500 errors that occur in tests. Lemme fix that real quick. |
Contributor
|
Ok, I just committed f307e2c to the |
Contributor
|
Urgg, sorry the 500 errors still have no tracebacks on this one--recognized my folly and fixed it in ff96154. 😞 |
Author
|
No worries--they were only the source of a little panic! I finally got all of the tests to pass though! I created a a separate error pages component with the blueprint error handler. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.