Fixes concurrency issues with error collection#172
Merged
NeedleInAJayStack merged 2 commits intoGraphQLSwift:mainfrom Dec 29, 2025
Merged
Fixes concurrency issues with error collection#172NeedleInAJayStack merged 2 commits intoGraphQLSwift:mainfrom
NeedleInAJayStack merged 2 commits intoGraphQLSwift:mainfrom
Conversation
Previously, errors would occasionally be underreported, which caused randomly failing tests. This is because when `append(error:` was called concurrently, it occasionally would overwrite a concurrently written `_errorsQueue`
This is unnecessary because we only ever write the property in its entirety without appending or modifying it in any way. This change may cause us to validate the schema multiple times concurrently early in our start up process, (which should end up with the same result), but the code simplification seems worth it.
NeedleInAJayStack
requested review from
Copilot and
paulofaria
and removed request for
Copilot
Member
Author
|
I'm going to go ahead and merge this to get the fix out there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, errors would occasionally be under-reported, which caused randomly failing tests. This is because when
append(error:was called concurrently, it occasionally would overwrite a concurrently written_errorsQueue.This also removes the schema
validationErrorsDispatchQueue. This queue is unnecessary because we only ever write the property in its entirety without appending or modifying it in any way. This change may cause us to validate the schema multiple times concurrently early in our start up process, (which should end up with the same result), but the code simplification seems worth it.