Uses GraphQLSwift CI#151
Merged
NeedleInAJayStack merged 2 commits intoGraphQLSwift:mainfrom Jul 4, 2025
Merged
Conversation
6d21c11 to
60f3625
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR switches the repository’s CI configuration to use the centralized GraphQLSwift CI workflows and updates several SubscribeField initializers to explicitly ignore an unused FieldType.Type parameter.
- Swap out local GitHub Actions in
.github/workflows/build.ymlfor calls to the shared GraphQLSwift CI repo. - Remove the old
build.ymlfile and introduce.github/workflows/test.yamlthat references the centralized lint and test workflows. - Update multiple
SubscriptionFieldconvenience initializers to mark theFieldType.Typeparameter as unused.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/Graphiti/Subscription/SubscribeField.swift | Changed as: FieldType.Type to as _: FieldType.Type to silence unused-parameter warnings |
| .github/workflows/test.yaml | Added workflow that uses GraphQLSwift/ci lint and test jobs |
| .github/workflows/build.yml | Removed local build workflow in favor of centralized CI |
Comments suppressed due to low confidence (1)
Sources/Graphiti/Subscription/SubscribeField.swift:453
- The
FieldType.Typeparameter is now ignored (using_). If this parameter is no longer needed, consider removing it from the API to simplify the initializer signature and avoid confusion for users.
as _: FieldType.Type,
paulofaria
reviewed
Jul 3, 2025
paulofaria
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches to the centralized GraphQLSwift CI repo for better maintainability.