Skip to content

Conversation

@sunng87
Copy link
Member

@sunng87 sunng87 commented Dec 10, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This patch adds support for Grafana query builder meta queries.
Upstream: datafusion-contrib/datafusion-postgres#259

It provides candidates for table and column
image

I also upgraded our flake environment to nixos-25.11

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@sunng87 sunng87 requested a review from a team as a code owner December 10, 2025 06:08
@github-actions github-actions bot added size/XS docs-not-required This change does not impact docs. labels Dec 10, 2025
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could we add some sqlness test?

Via command:

-- SQLNESS PROTOCOL POSTGRES
-- test sql --

@github-actions github-actions bot added size/S and removed size/XS labels Dec 10, 2025
@sunng87
Copy link
Member Author

sunng87 commented Dec 10, 2025

Sounds good. Test cases added.

@sunng87 sunng87 added this pull request to the merge queue Dec 11, 2025
Merged via the queue into GreptimeTeam:main with commit 276f6bf Dec 11, 2025
43 checks passed
@sunng87 sunng87 deleted the feature/grafana-postgresql-query-builder branch December 11, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants