Skip to content

Fixed SDgetcompinfo incorrect behavior #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bmribler wants to merge 1 commit into
base: hdf_4_3_1
Choose a base branch
from
Draft

Fixed SDgetcompinfo incorrect behavior #868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions hdf/src/hcomp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,6 @@ funclist_t comp_funcs = {
static int32
HCIinit_coder(int16 acc_mode, comp_coder_info_t *cinfo, comp_coder_t coder_type, comp_info *c_info)
{
uint32 comp_config_info;

HCget_config_info(coder_type, &comp_config_info);
if ((comp_config_info & (COMP_DECODER_ENABLED | COMP_ENCODER_ENABLED)) == 0) {
/* coder not present */
HRETURN_ERROR(DFE_BADCODER, FAIL);
}

switch (coder_type) { /* determine the type of encoding */
case COMP_CODE_NONE: /* "none" (i.e. no) encoding */
cinfo->coder_type = COMP_CODE_NONE; /* set coding type */
Expand Down
6 changes: 5 additions & 1 deletion mfhdf/dumper/testfiles/dumpsds-15.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ Variable Name = SDSszip
Type= 32-bit signed integer
Ref. = 6
Compression method = SZIP
Compression information is unavailable (no SZIP library)
Option mask = H4_SZ_EC_OPTION_MASK|H4_SZ_RAW_OPTION_MASK (132)
Copy link
Copy Markdown
Collaborator

@schwehr schwehr Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

Pixels per block = 2
Pixels per scanline = 5
Bits per pixel = 32
Pixels = 80
Compression ratio (original:compressed) = 2.67:1
Rank = 2
Number of attributes = 0
Expand Down
Loading