Skip to content

chore: fix grammar#6227

Merged
lrknox merged 1 commit intoHDFGroup:developfrom
hyoklee:hyoklee-hdf5-321
Feb 24, 2026
Merged

chore: fix grammar#6227
lrknox merged 1 commit intoHDFGroup:developfrom
hyoklee:hyoklee-hdf5-321

Conversation

@hyoklee
Copy link
Copy Markdown
Member

@hyoklee hyoklee commented Feb 20, 2026

"Community support forum available, please see:"
->
"A community support forum is available; please see:"


Important

Fix grammar in USING_HDF5_VS.txt for clarity in community support forum reference.

  • Documentation:
    • Fix grammar in USING_HDF5_VS.txt from "Community support forum available, please see:" to "A community support forum is available; please see:".

This description was created by Ellipsis for 8e25144. You can customize this summary. It will automatically update as commits are pushed.

@mattjala mattjala self-assigned this Feb 23, 2026
@lrknox lrknox merged commit 3bd0f17 into HDFGroup:develop Feb 24, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from To be triaged to Done in HDF5 - TRIAGE & TRACK Feb 24, 2026
@hyoklee hyoklee deleted the hyoklee-hdf5-321 branch February 25, 2026 03:27
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Feb 25, 2026
lrknox added a commit that referenced this pull request Feb 25, 2026
* Skip some parallel example tests for small MPIEXEC_MAX_NUMPROCS values (#6224)

* chore: fix grammar (#6227)

* Split static targets into separate optional target [UPDATED] (#6216)

Build-tree exports can't diverge from install-tree exports — the export(EXPORT ...) reads directly from the install export sets. No manual list to keep in sync.

Removed 3 global variables (HDF5_STATIC_LIBRARIES_TO_EXPORT, HDF5_JAVA_LIBRARIES_TO_EXPORT, HDF5_UTILS_TO_EXPORT) and their ~21 set_global_variable calls across tool/utility files.

Fixed the static-only build bug in the PR where the base export set was guarded by BUILD_SHARED_LIBS, breaking tools export.

Removed redundant utils in export files — the PR was dumping tools into all three build-tree export files (java, static, shared). Now they correctly appear only in the base export.

* Apply filters to variable-length data (#6178)

Closes can_apply and set_local filter callbacks skipped for H5T_VARIABLE dtypes #5942. A more detailed explanation of the rationale for this PR is in the linked issue.

Mandatory filters can be now applied to variable-length data. This notably includes h5py object strings and NpyStrings.

Optional filters applied to variable-length data no longer skip can_apply and set_local, only to jump directly to filter. This fixes hdf5_blosc and HDF5_Blosc2, which rely on set_local. Note that all filters which have neither can_apply nor set_local have always worked fine with vlen data, as long as they were tagged as optional. Notable examples are deflate, lzf, bzip2 (from hdf5plugin), and lz4 (also from hdf5plugin).

Lossy filters, such as scale-offset, are and remain untested and most likely broken, as I expect them to treat the vlen metadata as numbers and corrupt it. The right place to ensure proper behaviour is their can_apply function, which however is broken (filters: can_apply does nothing for optional filters #6161).
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Mar 18, 2026
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants