Skip to content

Suppress some CMake dev warnings for lower message log levels#6228

Merged
jhendersonHDF merged 1 commit intoHDFGroup:developfrom
jhendersonHDF:suppress_some_cmake_dev_warnings
Feb 23, 2026
Merged

Suppress some CMake dev warnings for lower message log levels#6228
jhendersonHDF merged 1 commit intoHDFGroup:developfrom
jhendersonHDF:suppress_some_cmake_dev_warnings

Conversation

@jhendersonHDF
Copy link
Copy Markdown
Collaborator

@jhendersonHDF jhendersonHDF commented Feb 20, 2026

Important

Suppresses developer warnings in HDF5Pkgconfig.cmake unless logging level is VERBOSE or DEBUG, using a new show_dev_warnings flag.

  • Behavior:
    • Suppresses developer warnings in extract_lib_pkgconfig_info in HDF5Pkgconfig.cmake unless logging level is VERBOSE or DEBUG.
    • Warnings about generator expressions are now conditional on show_dev_warnings flag.
  • Implementation:
    • Introduces show_dev_warnings flag based on cmake_msg_log_level.
    • Applies conditional warnings to message(AUTHOR_WARNING) calls for multi-config generators, generator expressions, and library name issues.

This description was created by Ellipsis for 52cbd3b. You can customize this summary. It will automatically update as commits are pushed.

if (num_configs GREATER "1")
message (AUTHOR_WARNING "Cannot generate pkg-config files correctly for multi-config generators")
if (show_dev_warnings)
message (AUTHOR_WARNING "Cannot generate pkg-config files correctly for multi-config generators")
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AUTHOR_WARNING (dev warning) messages appear to always be printed during CMake configure and quite a few get printed now when building with other libraries like filters. They're highlighting a real problem that needs to be fixed eventually but won't be of interest to most people, so suppress them behind VERBOSE or DEBUG log levels.

@mattjala mattjala self-assigned this Feb 23, 2026
@jhendersonHDF jhendersonHDF merged commit 4b1f873 into HDFGroup:develop Feb 23, 2026
125 checks passed
@github-project-automation github-project-automation Bot moved this from To be triaged to Done in HDF5 - TRIAGE & TRACK Feb 23, 2026
jhendersonHDF added a commit to jhendersonHDF/hdf5 that referenced this pull request Feb 23, 2026
@hyoklee hyoklee mentioned this pull request Feb 24, 2026
@jhendersonHDF jhendersonHDF deleted the suppress_some_cmake_dev_warnings branch March 18, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants