Skip to content

build: use CMAKE_DL_LIBS instead of hardcoded dl #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brtnfld merged 10 commits into from
May 7, 2026
Merged

build: use CMAKE_DL_LIBS instead of hardcoded dl #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bc51ddc
build: use CMAKE_DL_LIBS instead of hardcoded dl
brtnfld May 5, 2026
598feb4
ci: sanitize branch name slashes in tarball filename
brtnfld May 5, 2026
2e96b99
ci: update actions/checkout to v4.3.1 and opt into Node.js 24
brtnfld May 5, 2026
693a17e
ci: add Dependabot config for GitHub Actions updates
brtnfld May 5, 2026
53f3e63
ci: upgrade actions/checkout, upload-artifact, download-artifact to N…
brtnfld May 5, 2026
da1a558
build: use OPTIONAL_COMPONENTS for ZLIB static on Windows/vcpkg
brtnfld May 6, 2026
fe503f6
build: drop ZLIB static component request to fix vcpkg on Windows
brtnfld May 6, 2026
0dfee3c
build: skip ZLIB static component on Windows to fix vcpkg build
brtnfld May 6, 2026
34e71a8
build: add Blosc2 to NAMES for find_package on Windows/vcpkg
brtnfld May 6, 2026
94a349c
Revert "build: add Blosc2 to NAMES for find_package on Windows/vcpkg"
brtnfld May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
version: 2
updates:
- package-ecosystem: github-actions
directory: /
schedule:
interval: weekly
groups:
actions:
patterns:
- "*"
5 changes: 4 additions & 1 deletion .github/workflows/check-releases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ name: hdf5 plugins check compression releases
on:
workflow_call:

env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
Copy link
Copy Markdown
Contributor

@jhendersonHDF jhendersonHDF May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is setting these in various actions used for here?

Copy link
Copy Markdown
Contributor Author

@brtnfld brtnfld May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to get rid of the Node.js 20 actions are deprecated warnings


jobs:
check-compression-releases:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -170,7 +173,7 @@ jobs:

# Save json report
- name: Save json report
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: compression-versions
path: versions-file.json
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/clang-format-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'skip-ci')"
steps:
- uses: actions/checkout@v4.1.7
- uses: actions/checkout@v5.0.1

- name: Run clang-format style check for C and Java code
uses: DoozyX/clang-format-lint-action@v0.20
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/clang-format-fix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
permissions:
contents: write # In order to allow EndBug/add-and-commit to commit changes
steps:
- uses: actions/checkout@v4.1.7
- uses: actions/checkout@v5.0.1

- name: Fix C and Java formatting issues detected by clang-format
uses: DoozyX/clang-format-lint-action@v0.20
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/cmake-bintest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ on:
required: true
default: snapshots

env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true

permissions:
contents: read

Expand Down Expand Up @@ -69,7 +72,7 @@ jobs:

# Get files created by cmake-ctest script
- name: Get published plugins binary (Windows)
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: zip-vs2022_cl-binary
path: ${{ github.workspace }}/hdf5
Expand Down Expand Up @@ -180,7 +183,7 @@ jobs:

# Get files created by cmake-ctest script
- name: Get published plugins binary (Linux)
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: tgz-ubuntu-2404_gcc-binary
path: ${{ github.workspace }}
Expand Down Expand Up @@ -281,7 +284,7 @@ jobs:

# Get files created by cmake-ctest script
- name: Get published binary (MacOS_latest)
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: tgz-macos14_clang-binary
path: ${{ github.workspace }}
Expand Down
23 changes: 13 additions & 10 deletions .github/workflows/cmake-ctest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ on:
AZURE_CERT_PROFILE_NAME:
required: true

env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true

permissions:
contents: read

Expand Down Expand Up @@ -166,7 +169,7 @@ jobs:

# Get files created by release script
- name: Get zip-tarball (Windows)
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: zip-tarball
path: ${{ github.workspace }}
Expand Down Expand Up @@ -256,14 +259,14 @@ jobs:

# Save files created by ctest script
- name: Save published binary (Windows)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: zip-vs2022_cl-binary
path: ${{ runner.workspace }}/build/${{ steps.set-file-base.outputs.FILE_BASE }}-win-vs2022_cl.zip
if-no-files-found: error # 'warn' or 'ignore' are also available, defaults to `warn`

- name: Save published msi binary (Windows)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: msi-vs2022_cl-binary
path: ${{ runner.workspace }}/buildmsi/${{ steps.set-file-base.outputs.FILE_BASE }}-win-vs2022_cl.msi
Expand Down Expand Up @@ -348,7 +351,7 @@ jobs:

# Get files created by release script
- name: Get tgz-tarball (Linux)
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: tgz-tarball
path: ${{ github.workspace }}
Expand Down Expand Up @@ -402,21 +405,21 @@ jobs:

# Save files created by ctest script
- name: Save published binary (Linux)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: tgz-ubuntu-2404_gcc-binary
path: ${{ runner.workspace }}/build/${{ steps.set-file-base.outputs.FILE_BASE }}-ubuntu-2404_gcc.tar.gz
if-no-files-found: error # 'warn' or 'ignore' are also available, defaults to `warn`

- name: Save published binary deb (Linux)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: deb-ubuntu-2404_gcc-binary
path: ${{ runner.workspace }}/builddeb/${{ steps.set-file-base.outputs.FILE_BASE }}-ubuntu-2404_gcc.deb
if-no-files-found: error # 'warn' or 'ignore' are also available, defaults to `warn`

- name: Save published binary rpm (Linux)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: rpm-ubuntu-2404_gcc-binary
path: ${{ runner.workspace }}/buildrpm/${{ steps.set-file-base.outputs.FILE_BASE }}-ubuntu-2404_gcc.rpm
Expand Down Expand Up @@ -527,7 +530,7 @@ jobs:

# Get files created by release script
- name: Get tgz-tarball (MacOS_latest)
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: tgz-tarball
path: ${{ github.workspace }}
Expand Down Expand Up @@ -663,14 +666,14 @@ jobs:

# Save files created by ctest script
- name: Save published binary (MacOS_latest)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: tgz-macos14_clang-binary
path: ${{ runner.workspace }}/build/${{ steps.set-file-base.outputs.FILE_BASE }}-macos14_clang.tar.gz
if-no-files-found: error # 'warn' or 'ignore' are also available, defaults to `warn`

- name: Save published dmg binary (MacOS_latest)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: tgz-macos14_clang-dmg-binary
path: ${{ runner.workspace }}/builddmg/${{ steps.set-file-base.outputs.FILE_BASE }}-macos14_clang.dmg
Expand Down
23 changes: 13 additions & 10 deletions .github/workflows/cmake-script.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ on:
required: true
type: string

env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true

permissions:
contents: read

Expand Down Expand Up @@ -120,7 +123,7 @@ jobs:

# Get files created by release script
- name: Get zip-tarball (Windows)
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: zip-tarball
path: ${{ github.workspace }}
Expand Down Expand Up @@ -178,7 +181,7 @@ jobs:

# Save log files created by ctest script
- name: Save log (Windows_intel)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: cl-win-log
path: ${{ runner.workspace }}/hdf5_plugins/hdf5_plugins.log
Expand Down Expand Up @@ -256,7 +259,7 @@ jobs:

# Get files created by release script
- name: Get tgz-tarball (Linux)
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: tgz-tarball
path: ${{ github.workspace }}
Expand Down Expand Up @@ -305,7 +308,7 @@ jobs:

# Save log files created by ctest script
- name: Save log (Linux)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: gcc-ubuntu-log
path: ${{ runner.workspace }}/hdf5_plugins/hdf5_plugins.log
Expand Down Expand Up @@ -393,7 +396,7 @@ jobs:

# Get files created by release script
- name: Get tgz-tarball (MacOS_latest)
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: tgz-tarball
path: ${{ github.workspace }}
Expand Down Expand Up @@ -443,7 +446,7 @@ jobs:

# Save log files created by ctest script
- name: Save log (MacOS_latest)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: macos-log
path: ${{ runner.workspace }}/hdf5_plugins/hdf5_plugins.log
Expand Down Expand Up @@ -537,7 +540,7 @@ jobs:

# Get files created by release script
- name: Get zip-tarball (Windows_intel)
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: zip-tarball
path: ${{ github.workspace }}
Expand Down Expand Up @@ -599,7 +602,7 @@ jobs:

# Save log files created by ctest script
- name: Save log (Windows_intel)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: intel-win-log
path: ${{ runner.workspace }}/hdf5_plugins/hdf5_plugins.log
Expand Down Expand Up @@ -684,7 +687,7 @@ jobs:

# Get files created by release script
- name: Get tgz-tarball (Linux_intel)
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: tgz-tarball
path: ${{ github.workspace }}
Expand Down Expand Up @@ -736,7 +739,7 @@ jobs:

# Save log files created by ctest script
- name: Save log (Linux_intel)
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7.0.1
with:
name: intel-ubuntu-log
path: ${{ runner.workspace }}/hdf5_plugins/hdf5_plugins.log
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/daily-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ on:
pull_request:
branches: [ "master" ]

env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true

permissions:
contents: read

Expand All @@ -24,7 +27,7 @@ jobs:
run-ignore: ${{ steps.getinputs.outputs.INPUTS_IGNORE }}

steps:
- uses: actions/checkout@v4.1.7
- uses: actions/checkout@v5.0.1

- name: Get hdf5 release base name
uses: dsaltares/fetch-gh-release-asset@master
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- name: Get Sources
uses: actions/checkout@9a9194f87191a7e9055e3e9b95b8cfb13023bb08 # v4.1.7
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
with:
fetch-depth: 0
ref: '${{ github.head_ref || github.ref_name }}'
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ on:
type: string
required: true

env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true

permissions:
contents: read

Expand All @@ -22,7 +25,7 @@ jobs:
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- name: Get Sources
uses: actions/checkout@9a9194f87191a7e9055e3e9b95b8cfb13023bb08 # v4.1.7
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
with:
fetch-depth: 0
ref: '${{ github.head_ref || github.ref_name }}'
Expand Down
Loading
Loading