-
Notifications
You must be signed in to change notification settings - Fork 139
AB#173 Filter Traffic now results by vehicle mode #5601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vesameskanen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice proceedings again. In addition to the minor code remarks I made, there is one thing to improve: when an alert concerns many entities, they should be presented in sorted order. It is difficult to detect a single route from a list of 100.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most remarks got fixed, but some more left to do:
-
TrafficNowTransportModes contains citybikes, which is wrong
-
Filter list should be an intersection of config.transportModes and TrafficNowTransportModes. It makes no sense to show subway filter in Rovaniemi.
-
In hämeenlinna, there was an alert with lots of unknown entity types and a few stopOnRoute types. Alert got filtered when bus filter was set although stopOnRoute referred bus routes. This feels a bit wrong.
Proposed Changes
Adds a feature to filter Traffic now -results by vehicle mode

Pull Request Check List
Review