Skip to content

Conversation

@partisaani
Copy link
Contributor

Proposed Changes

Adds a feature to filter Traffic now -results by vehicle mode
image

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
  • Merge the pull request

@partisaani partisaani self-assigned this Dec 15, 2025
@partisaani partisaani changed the title AB#173 AB#173 Filter Traffic now results by vehicle mode Dec 15, 2025
Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice proceedings again. In addition to the minor code remarks I made, there is one thing to improve: when an alert concerns many entities, they should be presented in sorted order. It is difficult to detect a single route from a list of 100.

Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most remarks got fixed, but some more left to do:

  • TrafficNowTransportModes contains citybikes, which is wrong

  • Filter list should be an intersection of config.transportModes and TrafficNowTransportModes. It makes no sense to show subway filter in Rovaniemi.

  • In hämeenlinna, there was an alert with lots of unknown entity types and a few stopOnRoute types. Alert got filtered when bus filter was set although stopOnRoute referred bus routes. This feels a bit wrong.

image

@vesameskanen vesameskanen merged commit 6be509f into next Dec 17, 2025
1 check passed
@vesameskanen vesameskanen deleted the AB#173 branch December 17, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants