Skip to content

Comments

fix: correct find precedence in jsdoc-validation and deploy from dist/ in deploy-s3#418

Merged
pethers merged 2 commits intostricttypingfrom
copilot/sub-pr-407-again
Feb 21, 2026
Merged

fix: correct find precedence in jsdoc-validation and deploy from dist/ in deploy-s3#418
pethers merged 2 commits intostricttypingfrom
copilot/sub-pr-407-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 21, 2026

Two workflow bugs: find operator precedence causing over-broad file matching, and Vite build output being ignored during S3 deployment.

Changes

  • jsdoc-validation.yml: Wrap -name predicates in parentheses so -o is scoped to the target directories, not the entire filesystem

    # Before — matches *.ts everywhere due to -o binding
    find src/browser scripts -name "*.js" -o -name "*.ts"
    
    # After — correctly constrained to specified directories
    find src/browser scripts \( -name "*.js" -o -name "*.ts" \)
  • deploy-s3.yml: Change SRC="."SRC="dist" so all aws s3 sync commands deploy Vite-built artifacts instead of source files — the build step was effectively a no-op before this fix


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…dist/ in deploy-s3.yml

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Evening Analysis Content Validator for quality assessment fix: correct find precedence in jsdoc-validation and deploy from dist/ in deploy-s3 Feb 21, 2026
Copilot AI requested a review from pethers February 21, 2026 21:16
@pethers pethers marked this pull request as ready for review February 21, 2026 21:19
@pethers pethers merged commit e11ecba into stricttyping Feb 21, 2026
@pethers pethers deleted the copilot/sub-pr-407-again branch February 21, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants