fix: correct find precedence in jsdoc-validation and deploy from dist/ in deploy-s3#418
Merged
pethers merged 2 commits intostricttypingfrom Feb 21, 2026
Merged
Conversation
…dist/ in deploy-s3.yml Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Evening Analysis Content Validator for quality assessment
fix: correct find precedence in jsdoc-validation and deploy from dist/ in deploy-s3
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflow bugs:
findoperator precedence causing over-broad file matching, and Vite build output being ignored during S3 deployment.Changes
jsdoc-validation.yml: Wrap-namepredicates in parentheses so-ois scoped to the target directories, not the entire filesystemdeploy-s3.yml: ChangeSRC="."→SRC="dist"so allaws s3 synccommands deploy Vite-built artifacts instead of source files — the build step was effectively a no-op before this fix🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.