Improve and refactor patches.cjs in tx/ocl/shared#172
Open
italomacedo wants to merge 1 commit intomainfrom
Open
Improve and refactor patches.cjs in tx/ocl/shared#172italomacedo wants to merge 1 commit intomainfrom
italomacedo wants to merge 1 commit intomainfrom
Conversation
…s, bug fixes, or refactoring as needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the OCL ValueSet expansion and job queue prioritization, along with adjustments to cold cache loading and compose reconstruction. The main focus is on ensuring user-requested jobs are prioritized, reconstructing ValueSet compose data when missing, and grouping concepts by system during expansion. Several legacy behaviors and patches are commented out or refactored for clarity and maintainability.
Job Queue Prioritization
userRequestedflag to job objects inOCLBackgroundJobQueue, ensuring user-requested jobs are prioritized at the front of the queue (tx/ocl/jobs/background-queue.cjs). [1] [2]userRequestedflag when scheduling background expansions inOCLValueSetProvider, so cache hits triggered by user actions are prioritized (tx/ocl/vs-ocl.cjs). [1] [2]ValueSet Compose Reconstruction and Cold Cache Handling
compose.includeis missing, it is reconstructed fromexpansion.containsto ensure completeness and consistency (tx/ocl/vs-ocl.cjs).compose.includeis populated for each system, improving the structure and accuracy of ValueSet expansions (tx/ocl/vs-ocl.cjs). [1] [2] [3]Legacy and Patch Adjustments
compose.include.codeis commented out, reverting to the original expansion behavior (tx/ocl/shared/patches.cjs,tx/ocl/vs-ocl.cjs). [1] [2]#ensureComposeIncludescalls and preferred source handling (tx/ocl/vs-ocl.cjs). [1] [2] [3] [4] [5] [6] [7] [8]Indexing and Cache Management
tx/ocl/vs-ocl.cjs).