Skip to content

Conversation

@nsgocev
Copy link

@nsgocev nsgocev commented Jul 29, 2015

No description provided.

@RollForReflex
Copy link

Any chance we can go ahead and merge this?

@nbenninghoff
Copy link

Nice, I would further add Name to the Header. I was surprised it wasn't in the original and wonder what the reasoning was to exclude it. Item Name is a pretty important thing...

@SaintSkeeta
Copy link
Contributor

I think Name should not be put into GlassBase, and also Url should be removed from it.
We want GlassBase to be as slim as possible....and not include any unnecessary stuff, as ALL models will get it. With Glass, you only want what you'll need, otherwise the model construction is slowed down for no good reason.
We should look at easy ways to add properties like Name, Url etc through custom data.... saving re-doing it multiple times in partial classes, but making it easy to state which classes get these sorts of properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants