Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Nov 10, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The rescue MacOSVersion::Error never triggered as we convert the error to RuntimeError in

rescue MacOSVersion::Error, TypeError => e
raise "invalid 'depends_on macos' value: #{e}"

Try handling this earlier to retain the depends_on parts that are valid.

Need to test this out.

Copilot AI review requested due to automatic review settings November 10, 2025 17:18
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

This comment was marked as outdated.

@cho-m cho-m requested a review from Copilot November 10, 2025 18:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cho-m
Copy link
Member Author

cho-m commented Nov 10, 2025

Somewhat better but the odebug is causing an error message (reinstall still runs):

==> Fetching downloads for: handbrake-app
✔︎ Cask handbrake-app (1.10.2)                                         [Verifying    41.6MB/ 41.6MB]
Error: Unexpected method 'debug?' called on Cask handbrake-app.
Follow the instructions here:
  https://github.com/Homebrew/homebrew-cask#reporting-bugs

Will drop odebug for now to get bug fix out

@cho-m cho-m force-pushed the cask_loader-macos-version branch from 0895da5 to 2cc67ba Compare November 10, 2025 19:05
@cho-m cho-m marked this pull request as ready for review November 10, 2025 19:05
Copilot AI review requested due to automatic review settings November 10, 2025 19:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit 1874094 Nov 11, 2025
43 checks passed
@MikeMcQuaid MikeMcQuaid deleted the cask_loader-macos-version branch November 11, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants