[FIX] FileDelivery: Add ext. data directory support for X-Accel#11209
Open
mjansenDatabay wants to merge 1 commit intoILIAS-eLearning:release_10from
Open
[FIX] FileDelivery: Add ext. data directory support for X-Accel#11209mjansenDatabay wants to merge 1 commit intoILIAS-eLearning:release_10from
X-Accel#11209mjansenDatabay wants to merge 1 commit intoILIAS-eLearning:release_10from
Conversation
mjansenDatabay
force-pushed
the
hotfix/10/xaccel-ext-data-dir
branch
2 times, most recently
from
1e9def3 to
91b5abb
Compare
mjansenDatabay
force-pushed
the
hotfix/10/xaccel-ext-data-dir
branch
from
91b5abb to
c7d0a30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests supporting the external directory for the
XAccelResponseBuilder.Since we have no "Environment" (no initialized ILIAS) in the execution context of the
deliver.php, I read the path to the external ILIAS data directory from theilias.ini.phpand added it to the generated artifact file when it is created by the setup on install/update.If approved, this must be picked to
release_11andtrunkas well.See: https://mantis.ilias.de/view.php?id=45048