Cleaned up the repository by removing unnecessary packages#112
Merged
SylvainTakerkart merged 1 commit intoINT-NIT:mainfrom Feb 19, 2025
Merged
Cleaned up the repository by removing unnecessary packages#112SylvainTakerkart merged 1 commit intoINT-NIT:mainfrom
SylvainTakerkart merged 1 commit intoINT-NIT:mainfrom
Conversation
Collaborator
SylvainTakerkart
left a comment
SylvainTakerkart
left a comment
There was a problem hiding this comment.
Hi! Thanks for this!
I just have one question before accepting to merge: all the source code that your remove from here is still valuable... Where will it be stored now that it's not in DigLabTools anymore?
Contributor
Author
|
Yes, all the necessary code has been migrated to the bep32tools repository.
Le mer. 19 févr. 2025 à 10:50, Sylvain Takerkart ***@***.***>
a écrit :
… ***@***.**** commented on this pull request.
Hi! Thanks for this!
I just have one question before accepting to merge: all the source code
that your remove from here is still valuable... Where will it be stored now
that it's not in DigLabTools anymore?
—
Reply to this email directly, view it on GitHub
<#112 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A33HPUWLPJZIYIYJFEMXWGT2QRHXZAVCNFSM6AAAAABXLIV5YSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMRWGIZDOOJTHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
OK, good! But I guess you migrated it only on your local copy of Bep032Tools, because there's not PR to add this code there yet, no? Anyhow, we can accept this PR ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We aim to remove the bepv01 package from the DigLabTools repository to clean it up. This package is irrelevant and does not belong in this repository.