Skip to content

Feature: Print also debug output of eescheme_do when logger set to debug level#17

Merged
set-soft merged 3 commits intoINTI-CMNB:masterfrom
Tony763:debug-eescheme_do
Mar 25, 2025
Merged

Feature: Print also debug output of eescheme_do when logger set to debug level#17
set-soft merged 3 commits intoINTI-CMNB:masterfrom
Tony763:debug-eescheme_do

Conversation

@Tony763
Copy link
Contributor

@Tony763 Tony763 commented Mar 21, 2025

Hello, I did like to propose enabling very verbose output in eescheme_do when kicad-diff's logger is set to Debug level.

@set-soft
Copy link
Member

Hi @Tony763 !
This is a very good idea, can you modify the patch so it passes the same amount of debug level? I mean, if we get -v pass -v and if we get -vvvv pass -vvvv

@Tony763
Copy link
Contributor Author

Tony763 commented Mar 22, 2025

Sure thing, now are all -vv+ passed down to all commands run by run_command function and printed as debug message.

Using -v won't pass down so log contain just output of scripts.
This can be of course changed, in two ways:

  1. set logger to warning from debug, fast, but you will always get output from ext. tools
  2. when setting VERB count -1, this will result in:
  • -v - info and warnings from your script
  • -vv - debug output of your script and also -v from ext tool
  • -vvv - above, but -vv from ext tool and so

What would you prefer?

@set-soft
Copy link
Member

Number 2 is coherent with the original design. KiDiff is somehow "shifted", so passing the verbosity level - 1 looks coherent

@Tony763
Copy link
Contributor Author

Tony763 commented Mar 22, 2025

Updated.

@set-soft set-soft merged commit d907839 into INTI-CMNB:master Mar 25, 2025
2 checks passed
@set-soft
Copy link
Member

Thanks!

set-soft added a commit that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants