Skip to content

Conversation

@Anyexyz
Copy link

@Anyexyz Anyexyz commented Oct 19, 2025

Description 📣

This PR adds Simplified Chinese translations for the Infisical web interface and configuration files.
It enhances accessibility for Chinese-speaking users and improves the global usability of the project.

No breaking changes were introduced, and existing language files remain unaffected.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

The following tests were performed to verify the translations:

# Run development server
npm run dev

# Steps:
# 1. Switch the application language to "中文 (Simplified Chinese)".
# 2. Verify that all UI components (dashboard, settings, billing, audit logs, etc.) display correct translations.
# 3. Ensure no broken keys or missing placeholders appear in the console.

@maidul98
Copy link
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR adds comprehensive Simplified Chinese (zh) translations to the Infisical frontend by introducing a new translation file at frontend/public/locales/zh/translations.json. The file follows the existing i18n pattern used for Spanish and Korean locales, containing translations for all major application sections including activity logs, billing, dashboard, integrations, authentication, navigation, settings, and admin interfaces. The translation keys maintain consistency with other locale files, ensuring the i18n framework can automatically detect and use these translations when users select Chinese as their language preference. This is a purely additive change that expands the application's international reach without modifying any application logic or existing language files.

Changed Files
Filename Score Overview
frontend/public/locales/zh/translations.json 5/5 Added complete Simplified Chinese translation file with 344 lines covering all major application sections including activity, billing, common UI, dashboard, integrations, authentication, navigation, and settings

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only adds a new translation file without modifying existing code or logic
  • Score reflects that this is a purely additive internationalization enhancement with no code changes, no potential security issues, and proper JSON structure matching existing locale patterns
  • No files require special attention - the translation file follows established patterns and contains standard UI text translations

Sequence Diagram

sequenceDiagram
    participant User
    participant "Frontend Application" as Frontend
    participant "Locale System" as Locale
    
    User->>Frontend: "Access application"
    Frontend->>Locale: "Load default locale (en)"
    Locale-->>Frontend: "Return English translations"
    Frontend-->>User: "Display UI in English"
    
    User->>Frontend: "Select Chinese (zh) language"
    Frontend->>Locale: "Load zh/translations.json"
    Locale-->>Frontend: "Return Chinese translations"
    Frontend->>Frontend: "Re-render UI components with new locale"
    Frontend-->>User: "Display UI in Simplified Chinese"
    
    User->>Frontend: "Navigate to dashboard"
    Frontend->>Locale: "Fetch translations.dashboard keys"
    Locale-->>Frontend: "Return localized dashboard strings"
    Frontend-->>User: "Show dashboard with Chinese text"
    
    User->>Frontend: "Navigate to settings"
    Frontend->>Locale: "Fetch translations.settings keys"
    Locale-->>Frontend: "Return localized settings strings"
    Frontend-->>User: "Show settings with Chinese text"
    
    User->>Frontend: "View billing page"
    Frontend->>Locale: "Fetch translations.billing keys"
    Locale-->>Frontend: "Return localized billing strings"
    Frontend-->>User: "Show billing page with Chinese text"
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants