-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Move nock to dev deps and include the route only for dev/test builds #4874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
1f05fe1 to
fc9e787
Compare
Greptile Summary
Confidence Score: 1/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 2 comments
|
@greptile-apps review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 2 comments
c9c51a2 to
8f46044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
17 files reviewed, 2 comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
6ac4f70 to
57d204c
Compare
de784af to
6f4ae83
Compare
# Conflicts: # backend/src/server/routes/v1/bdd-nock-router.ts
This reverts commit 57d204c.
6f4ae83 to
af40e15
Compare
We had problem with nock module in the production build. It turned out that importing the nock module and not even using it causes it to intercepts all the outgoing requests (while doing nothing about them) and increase the memory footprint a lot. We commented out the route for nock. This PR brought back the nock route with the following measurements to make sure it won't be included in the production build:
@bdd_routes/bdd-nock-routerand mapped tobackend/src/server/routes/bdd/bdd-nock-router.tsby default.tsconfig.dev.jsonmapping@bdd_routes/bdd-nock-routerto@bdd_routes/bdd-nock-router.dev.tsinstead. This TS config will only be used in dev environmentsbdd-nock-router.dev.tsin production should now crash the app so that Kubernetes won't be able to roll it out due to bad readiness/healthy checkTo test this PR, one can run
To see if the
distfolder includes the dev version of nock route. One can also checkdist/server/routes/bdd/bdd-nock-router.mjs's content to see if the production one is included.For the dev environment, we have replaced all the tsc or similar command to use the
devversion oftsconfig. Otherwise CI won't even pass.