-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Chef PKI sync #4897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chef PKI sync #4897
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile Summary
Confidence Score: 3/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (3)
-
backend/src/ee/services/app-connections/chef/chef-connection-fns.ts, line 62 (link)syntax: native regex
.replace(/\.\d{3}Z$/, "Z")should use RE2 -
backend/src/ee/services/app-connections/chef/chef-connection-fns.ts, line 105 (link)syntax: native regex
.match(/.{1,60}/g)should use RE2 -
backend/src/ee/services/app-connections/chef/chef-connection-fns.ts, line 31-51 (link)syntax: native regex instead of RE2 creates ReDoS vulnerability
The
formatPrivateKeyfunction uses native JavaScript regex (lines 35, 38, 46, 49) which violates the custom rule requiring RE2 package for all regex operations. Replace all.replace()calls with RE2 equivalents:new RE2(pattern, flags).replace(string, replacement). Verify patterns at https://devina.io/redos-checker
38 files reviewed, 4 comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Description 📣
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets