Skip to content

Conversation

@victorvhs017
Copy link
Contributor

@victorvhs017 victorvhs017 commented Nov 25, 2025

Description 📣

This PR removes all mentions in the documentation to Native Integrations, including the API Reference.

We also removed the Native Integrations tab for the UI:

image

It will only show if the project already has a Native Integration created. In this case, we hide the button to create new ones and show an alert:

image

The API will still work for now to prevent the customer pipeline from breaking while we observe the usage through PostHog events. We already had one event for Integration Created, but now we are adding one for syncs and another for deletion. Based on this data, in the future, we can move along with a more complete phase-out. For now, the goal is to prevent new ones from being created in the UI.

image

Auto-syncs

image

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

  • Check if we don't mention Native Integrations in the documentation anymore
  • Go to the Integrations tab in the app. If you don't have a Native Integration set for the project already, you won't see the tab on the left.
  • If you have at least one Native Integration already set for the project, you will see the tab and all your Native Integrations, but you won't be able to create new ones (you still can edit and delete).
  • You should see a warning banner message above the Native Integrations panel with more information about the phase-out.
  • Check the 2 new PostHog events added (integration deleted and integration synced). You can test the events using your own PostHog project by commenting out this code in the telemetry-service.ts:
      const instanceType = licenseService.getInstanceType();
      // capture posthog only when its cloud or signup event happens in self-hosted
      if (instanceType === InstanceType.Cloud || event.event === PostHogEventTypes.UserSignedUp) {

And setting these env variables:

# Enable telemetry
TELEMETRY_ENABLED=true

# Your PostHog configuration
POSTHOG_HOST=https://app.posthog.com   # or your self-hosted PostHog URL
POSTHOG_PROJECT_API_KEY=phc_your_project_api_key_here

@maidul98
Copy link
Collaborator

maidul98 commented Nov 25, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 25, 2025

Greptile Overview

Greptile Summary

This PR begins phasing out Native Integrations in favor of Secret Syncs by blocking creation of new native integrations while preserving existing ones. The backend now returns 403 Forbidden errors for POST endpoints that create new integrations, the frontend conditionally hides the Native Integrations tab for users without existing integrations, and extensive documentation has been removed or updated.

Key Changes:

  • Blocks POST /api/v1/integration and POST /api/v1/integration-auth/access-token with deprecation errors
  • Preserves all read, update, delete, and sync operations for existing integrations
  • Frontend shows Native Integrations tab only when user has existing integrations, with deprecation warning banner
  • Removes 349 lines of OAuth redirect logic and deprecated environment variables
  • Updates documentation to reflect Secret Syncs as replacement

Critical Issues:

  • Breaking API Changes: Two POST endpoints now return 403 for ALL requests, which will break Terraform providers, SDK users, and any API consumers without warning or versioning strategy
  • API documentation still shows successful 200 responses that are now unreachable

Confidence Score: 3/5

  • This PR has breaking API changes that will immediately impact API consumers without deprecation period or versioning
  • Score reflects well-executed code changes with proper error messages and frontend UX, but critical concern about breaking API changes for Terraform/API users. The immediate 403 blocking without API versioning or sunset period violates the repository's guideline against breaking changes (Rule 7). Implementation is clean and reversible (commented code preserved), but deployment strategy needs careful coordination with users.
  • Pay close attention to backend/src/server/routes/v1/integration-auth-router.ts:340 and backend/src/server/routes/v1/integration-router.ts:71 - these introduce breaking API changes that need migration strategy

Important Files Changed

File Analysis

Filename Score Overview
backend/src/server/routes/v1/integration-auth-router.ts 4/5 Adds deprecation error to POST /access-token endpoint blocking new native integration authentications; existing endpoints remain functional
backend/src/server/routes/v1/integration-router.ts 4/5 Blocks POST / endpoint for creating new native integrations with deprecation error; update, read, delete, and sync endpoints remain active for existing integrations
frontend/src/pages/secret-manager/IntegrationsListPage/IntegrationsListPage.tsx 5/5 Conditionally shows Native Integrations tab only when existing integrations present; adds deprecation warning banner directing users to Secret Syncs
.env.example 5/5 Removes deprecated OAuth client credentials for Heroku, Vercel, Netlify, and Bitbucket native integrations; keeps GitHub and GitLab for CICD integrations

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

64 files reviewed, 5 comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! few comments

…nd update project role permissions to reflect workspace integrations
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorvhs017 victorvhs017 merged commit f0df6eb into main Nov 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants