-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Feature: start the phase out for Native Integrations #4947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ate API routes and frontend components accordingly
…n IntegrationsListPage
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile OverviewGreptile SummaryThis PR begins phasing out Native Integrations in favor of Secret Syncs by blocking creation of new native integrations while preserving existing ones. The backend now returns 403 Forbidden errors for POST endpoints that create new integrations, the frontend conditionally hides the Native Integrations tab for users without existing integrations, and extensive documentation has been removed or updated. Key Changes:
Critical Issues:
Confidence Score: 3/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
64 files reviewed, 5 comments
frontend/src/pages/secret-manager/IntegrationsListPage/IntegrationsListPage.tsx
Show resolved
Hide resolved
…eamline integration token saving process in API routes
…on, including new event types and properties
… integration deletion event metadata
scott-ray-wilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! few comments
frontend/src/pages/secret-manager/IntegrationsListPage/IntegrationsListPage.tsx
Outdated
Show resolved
Hide resolved
…nd update project role permissions to reflect workspace integrations
scott-ray-wilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description 📣
This PR removes all mentions in the documentation to Native Integrations, including the API Reference.
We also removed the Native Integrations tab for the UI:
It will only show if the project already has a Native Integration created. In this case, we hide the button to create new ones and show an alert:
The API will still work for now to prevent the customer pipeline from breaking while we observe the usage through PostHog events. We already had one event for Integration Created, but now we are adding one for syncs and another for deletion. Based on this data, in the future, we can move along with a more complete phase-out. For now, the goal is to prevent new ones from being created in the UI.
Auto-syncs
Type ✨
Tests 🛠️
telemetry-service.ts:And setting these env variables: