Skip to content

Add MacOS install documentation #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Morgandri1 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add MacOS install documentation #3

Morgandri1 wants to merge 5 commits into from

Conversation

@Morgandri1
Copy link

@Morgandri1 Morgandri1 commented Nov 21, 2023

This PR adds full documentation about how to install Injectived on MacOS (apple silicon and intel) for uploading contracts to testnet as well as any other uses of injectived.

Fixes:

  • add MacOS install documentation to Readme
  • give instructions for .zshrc updates

gorgos
gorgos suggested changes Nov 23, 2023
View reviewed changes
Copy link

@gorgos gorgos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please start sentences with capital letter, as well as use single ` for the path

README.md Outdated
make install
```

2. update ``.zshrc`` - Add these lines to your ``~/.zshrc`` file:
Copy link

@gorgos gorgos Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or .bashrc for people with bash

README.md Outdated
export GOPRIVATE=github.com/InjectiveLabs/injective-core
```

3. refresh your ``~/.zshrc`` file
Copy link

@gorgos gorgos Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again or bashrc

@Morgandri1
Copy link
Author

Morgandri1 commented Nov 23, 2023

@gorgos take a look now. I could also add my install script which detects bash vs. zsh.

gorgos
gorgos suggested changes Nov 23, 2023
View reviewed changes
Copy link

@gorgos gorgos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay almost good now

README.md Outdated
1. Build from source
```bash
git clone https://github.com/OpenDeFiFoundation/injective-core.git
git clone https://github.com/InjectiveLabs/injective-core.git
Copy link

@gorgos gorgos Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No please change back. I meant just removing the other line

@Morgandri1
Copy link
Author

Morgandri1 commented Nov 23, 2023

Should i add my MacOS install script?

gorgos
gorgos suggested changes Nov 23, 2023
View reviewed changes
README.md Outdated
```bash
export GOPATH=$HOME/go
export PATH=$PATH:$(go env GOPATH)/bin
export GOPRIVATE=github.com/OpenDeFiFoundation/injective-core
Copy link

@gorgos gorgos Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line

Morgandri1
Morgandri1 commented Jan 13, 2024
View reviewed changes
Copy link
Author

@Morgandri1 Morgandri1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed GOPRIVATE line

@Morgandri1 Morgandri1 requested a review from gorgos January 13, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gorgos gorgos Awaiting requested review from gorgos

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Morgandri1 @gorgos