fix: raw response to response process with 'interrogation id' duplicates#445
Open
nsenave wants to merge 37 commits intodevReprocessRawDatasfrom
Open
fix: raw response to response process with 'interrogation id' duplicates#445nsenave wants to merge 37 commits intodevReprocessRawDatasfrom
nsenave wants to merge 37 commits intodevReprocessRawDatasfrom
Conversation
…rocess-duplicates
nsenave
requested review from
Hajarel-moukh and
loichenninger
and removed request for
Hajarel-moukh
nsenave
commented
Apr 9, 2026
| dataProcessingContextService.getContextByCollectionInstrumentId(collectionInstrumentId); | ||
| List<GenesisError> errors = new ArrayList<>(); | ||
| List<RawResponseModel> rawResponseModels = getRawResponses(collectionInstrumentId, mode, interrogationIdToProcess); | ||
| rawResponseModels.removeIf(rawResponseModel -> rawResponseModel.processDate() != null); |
Contributor
Author
There was a problem hiding this comment.
📄 C'est le seul changement fonctionnel dans cette PR sur cette ligne (le reste est du refacto)
|
nsenave
commented
Apr 9, 2026
| surveyUnitService.saveSurveyUnits(...), but calls | ||
| processRawResponsesByInterrogationIds(String collectionInstrumentId, List<String> interrogationIds, List<GenesisError> errors), | ||
| the assertion "surveyUnitService.saveSurveyUnits(...) should be called" no longer passes. | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
@alexisszmundy j'aurais besoin de ton aide pour régler ces cas de tests
Hajarel-moukh
approved these changes
Apr 9, 2026
Hajarel-moukh
force-pushed
the
devReprocessRawDatas
branch
from
ac921d6 to
9a4e6ec
Compare
alicela
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏗️ J'adosse ma PR à celle du reprocess pour l'instant, pour avoir le refacto que j'avais fait là-bas.
Le problème : quand on a des doublon d'identifiant d'interrogation dans les réponses brutes, on peut avoir ce genre de situation
interrogationId: 1, processDate: 08/04/2026(a été processed)interrogationId: 1, processDate: null(est arrivée après, pas encore processed)(processed = intégrée dans la table des
responsedepuis la table desrawResponse)Dans ce cas là, le service qui process va convertir les deux réponses brutes avec l'id
1en réponses "survey unit", alors qu'une des deux a déjà été processedUniquement le cas "raw response". Je ferai le fix pour le données legacy "Lunatic raw data" dans une autre PR