Skip to content

Prepare for wasm #5229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Prepare for wasm #5229

wants to merge 4 commits into from

Conversation

@palas
Copy link

@palas palas commented Oct 20, 2025

Description

This PR patches the parts of ouroboros-network that make compilation fail for wasm. I have done two commits, because of the decision to undo removal of "deprecation warnings", in case we reconsider, but let's squash before merging.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@palas palas self-assigned this Oct 20, 2025
@palas palas requested a review from a team as a code owner October 20, 2025 23:48
@palas palas added the maintenance Issues / PRs related to maintenance of any of the compoents. label Oct 20, 2025
@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Oct 20, 2025
@coot
Copy link
Collaborator

coot commented Oct 21, 2025 •
edited
Loading

Could you add a cross compilation target to wasm using nix? Otherwise, sooner or later it will get broken. This could answer the first question :).

@palas
Copy link
Author

palas commented Oct 21, 2025

Could you add a cross compilation target to wasm using nix? Otherwise, sooner or later it will get broken. This could answer the first question :)

I don't now how to do it with haskell.nix yet, I'll ask if it is possible. So far, I made a GHA job in cardano-api but it involves some more conditional SRPs for dependencies and some extra nix code for libraries with C bindings. We have it non-required so that it is a warning but doesn't disturb the development.

@palas palas requested a review from a team as a code owner October 24, 2025 01:39
@palas palas requested a review from coot October 27, 2025 13:18
@palas palas moved this from In Progress to In Review in Ouroboros Network Nov 4, 2025
coot
coot approved these changes Nov 27, 2025
View reviewed changes
Copy link
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments.

cardano-diffusion/lib/Cardano/Network/NodeToNode.hs
Comment on lines +427 to +429
#else
connectTo _ _ = error "connecTo not supported in wasm"
#endif
Copy link
Collaborator

@coot coot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally removed an empty line which delimits two definitions.

Suggested change
#else
connectTo _ _ = error "connecTo not supported in wasm"
#endif
#else
connectTo _ _ = error "connecTo not supported in wasm"
#endif

network-mux/src/Network/Mux/Channel.hs
--- This is primarily for testing purposes since it does not allow actual IPC.
---
-- __Exceptions:__
-- May throw 'IOError' when compiling to @wasm@.
Copy link
Collaborator

@coot coot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- May throw 'IOError' when compiling to @wasm@.
-- May throw 'IOError' when running on @wasm@.

The original suggests that Template Haskell is used.

ouroboros-network/demo/connection-manager.hs


-- | __Exceptions:__
-- May throw 'IOError' when compiling to @wasm@.
Copy link
Collaborator

@coot coot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- May throw 'IOError' when compiling to @wasm@.
-- May throw 'IOError' when running on @wasm@.

ouroboros-network/framework/lib/Ouroboros/Network/Snocket.hs
-- 'Socket.ReuseAddr` and 'Socket.ReusePort'.
--
-- __Exceptions:__
-- May throw 'IOError' when compiling to @wasm@.
Copy link
Collaborator

@coot coot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- May throw 'IOError' when compiling to @wasm@.
-- May throw 'IOError' when running on @wasm@.

ouroboros-network/framework/lib/Ouroboros/Network/Snocket.hs
-- referenced by 'LocalSocket'.
--
-- __Exceptions:__
-- May throw 'IOError' when compiling to @wasm@.
Copy link
Collaborator

@coot coot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- May throw 'IOError' when compiling to @wasm@.
-- May throw 'IOError' when running on @wasm@.

ouroboros-network/tests/io/Test/Ouroboros/Network/Socket.hs


-- | __Exceptions:__
-- May throw 'IOError' when compiling to @wasm@.
Copy link
Collaborator

@coot coot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- May throw 'IOError' when compiling to @wasm@.
-- May throw 'IOError' when running on @wasm@.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coot coot coot approved these changes

Assignees

@palas palas

Labels

maintenance Issues / PRs related to maintenance of any of the compoents.

Projects

Ouroboros Network
Status: In Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@palas @coot