comments added for learning purposes.#6
Open
tistudios wants to merge 2 commits intoIntuitDeveloper:masterfrom
Open
comments added for learning purposes.#6tistudios wants to merge 2 commits intoIntuitDeveloper:masterfrom
tistudios wants to merge 2 commits intoIntuitDeveloper:masterfrom
Conversation
added closing php tag
|
Your request changes one of the quotation marks to an apostrophe, but not the ending mark. These should both be changed since interpolation is not occurring within that string. Additionally, a closing PHP tag isn't strictly necessary and there are various positive points supporting leaving the tag out within a PHP-only file. |
Author
|
The first one was made in error. Thanks for catching that. Re 2nd point, thanks for letting me know its considered poor practice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added closing php tag