Adding In-App support for fully compose apps#977
Adding In-App support for fully compose apps#977franco-zalamena-iterable wants to merge 3 commits intomasterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
iterableapi/src/main/java/com/iterable/iterableapi/InAppWebViewService.kt
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppDialogNotification.kt
Dismissed
Show dismissed
Hide dismissed
| val loc = location ?: IterableInAppLocation.IN_APP | ||
|
|
||
| if (iterableApi != null) { | ||
| iterableApi.trackInAppOpen(messageId, loc) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
There was a problem hiding this comment.
@Ayyanchira What can be the replacement for that, since the same one is used in IterableInAppFragmentHTMLNotification:288
| val loc = location ?: IterableInAppLocation.IN_APP | ||
|
|
||
| if (iterableApi != null) { | ||
| iterableApi.trackInAppClick(messageId, url, loc) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
There was a problem hiding this comment.
@Ayyanchira What can be the replacement for that, since the same one is used in IterableInAppFragmentHTMLNotification:354
| val loc = location ?: IterableInAppLocation.IN_APP | ||
|
|
||
| if (iterableApi != null) { | ||
| iterableApi.trackInAppClose(messageId, url, closeAction, loc) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
There was a problem hiding this comment.
@Ayyanchira What can be the replacement for that, since the same one is used in IterableInAppFragmentHTMLNotification:370
2 participants
🔹 Jira Ticket(s) if any
✏️ Description
Adding support for fully compose apps to have in-app messages without problems.
On IterableInAppDisplayer, we now detect if the activity is a ComponentActivity or FragmentActivity.
We now have an IterableInAppDialogNotification.kt for handling In-Apps for fully compose apps.
There is also InAppServices for handling the InApp actions, layout, etc., currently only implemented on the DialogNotification but created for sharing logic between the fragment and compose implementations