Skip to content

Conversation

@baltzell
Copy link
Collaborator

@baltzell baltzell commented Dec 23, 2025

In preparation for new swimming versions, do a little reorganization of org.jlab.clas.swimtools:

  • Add ISwim interface of appropriate methods from Swim
  • Add abstract ASwim for shared data and generic wrapping of some simple geometry calls
  • Refactor Swim, now extends ASwim
    • Move stoppers to a new, separate class Stoppers
    • Move parameter setup to a new, separate class SwimPars
    • Move existing "new" adaptive methods, previously unused, to AdaptiveSwim
    • Remove some unused methods
  • Add AdaptiveSwim with specific methods from Swim
  • General cleanup

TODO: remove stuff from ISwim, add wrappers to ASwim.

Note, Swim's interface and functionality is unchanged.

@baltzell baltzell marked this pull request as ready for review December 23, 2025 22:59
@baltzell baltzell force-pushed the swim-baltzell branch 2 times, most recently from 9e8f239 to aef9bc2 Compare January 6, 2026 00:33
@baltzell baltzell enabled auto-merge (squash) January 6, 2026 01:48
@baltzell baltzell added the speed label Jan 6, 2026
@baltzell baltzell force-pushed the swim-baltzell branch 2 times, most recently from 10fdb0f to 28d28ff Compare January 7, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants