Skip to content

Detector changed hook #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
baltzell wants to merge 50 commits into
base: development
Choose a base branch
from
Draft

Detector changed hook #905

baltzell wants to merge 50 commits into from

Conversation

@baltzell
Copy link
Collaborator

@baltzell baltzell commented Oct 23, 2025

No description provided.

@baltzell baltzell added this to the Real Run Number Simulations milestone Oct 23, 2025
@baltzell baltzell added the gemc label Oct 23, 2025
@baltzell baltzell force-pushed the detector-changed-hook branch 3 times, most recently from 509c95a to 8492640 Compare November 13, 2025 23:25
@baltzell baltzell mentioned this pull request Dec 3, 2025
Closed
@baltzell baltzell force-pushed the detector-changed-hook branch 3 times, most recently from cbbe1a5 to 5f34968 Compare December 12, 2025 20:30
@baltzell baltzell force-pushed the detector-changed-hook branch 4 times, most recently from 97bf69f to d290802 Compare December 23, 2025 15:39
@baltzell baltzell mentioned this pull request Jan 9, 2026
Closed
baltzell and others added 28 commits January 12, 2026 10:00
@baltzell
processDataEvent should be final
7e985e4
@baltzell
cleanup script
62e1ba7
@baltzell
remove unused/unnecessary script
8a50a17
@baltzell
disable workflow for now
91169cd
@baltzell
add neutron test
3b64d09
@baltzell
remove leftovers
41fdd94
@baltzell
abort on error
3fc81e3
@baltzell
fix rebase mistake
bfd9823
@baltzell
add missing overrides
ebfc4aa
@baltzell
add missing overrides
0a4939e
@baltzell
add missing overrides
14a0429
@raffaelladevita @baltzell
accounting for tstart, tflight and tprop in MC tracks reconstruction
3daab55
@raffaelladevita @baltzell
removed check on run number when setting the DC hit uncertainty
2fb5fcc
@raffaelladevita @baltzell
removed hardcoded change to default variation in BAND engine
9c82313
@raffaelladevita @baltzell
apply TDC jitter correction only if TI timestamp is >0, excluding MC …
915e056 
…events
@raffaelladevita @baltzell
moved RF offsets to time written to RUN::rf bank
7fa3fe4
@raffaelladevita @baltzell
fixed bug in REC::Event.RFTime introduced with last commit
c846e07
@raffaelladevita @baltzell
restored TDC jitter correction for timestamp=0
4bb183f
@raffaelladevita @baltzell
switch to load geometry for real run number
a94d6b9
@baltzell
fix env
6da5da4
@baltzell
add missing override
7a272c6
@baltzell
remove unused imports
49054bb
@baltzell
set PATH
a0484b5
@baltzell
add missing overrides
502577a
@baltzell
add missing overrides
b984f61
@raffaelladevita @baltzell
propagate detectorChanged and method renaming to new UberEngine
f2d39b5
@raffaelladevita @baltzell
changed EC to load the geometry with the real run number
688ef74
@baltzell
fix merge mistake
124232c
@baltzell baltzell force-pushed the detector-changed-hook branch from e84fd3e to 124232c Compare January 12, 2026 15:01
@baltzell
Copy link
Collaborator Author

baltzell commented Jan 12, 2026

If not already done, #441's changes should be included here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raffaelladevita raffaelladevita Awaiting requested review from raffaelladevita raffaelladevita will be requested when the pull request is marked ready for review raffaelladevita is a code owner

@c-dilks c-dilks Awaiting requested review from c-dilks c-dilks will be requested when the pull request is marked ready for review c-dilks is a code owner

@zieglerv zieglerv Awaiting requested review from zieglerv zieglerv will be requested when the pull request is marked ready for review zieglerv is a code owner

@tongtongcao tongtongcao Awaiting requested review from tongtongcao tongtongcao will be requested when the pull request is marked ready for review tongtongcao is a code owner

@mathieuouillon mathieuouillon Awaiting requested review from mathieuouillon mathieuouillon will be requested when the pull request is marked ready for review mathieuouillon is a code owner

@Hattawy Hattawy Awaiting requested review from Hattawy Hattawy will be requested when the pull request is marked ready for review Hattawy is a code owner

@drewkenjo drewkenjo Awaiting requested review from drewkenjo drewkenjo will be requested when the pull request is marked ready for review drewkenjo is a code owner

@mcontalb mcontalb Awaiting requested review from mcontalb mcontalb will be requested when the pull request is marked ready for review mcontalb is a code owner

@silvianic silvianic Awaiting requested review from silvianic silvianic will be requested when the pull request is marked ready for review silvianic is a code owner

@N-Plx N-Plx Awaiting requested review from N-Plx N-Plx will be requested when the pull request is marked ready for review N-Plx is a code owner

@rafopar rafopar Awaiting requested review from rafopar rafopar will be requested when the pull request is marked ready for review rafopar is a code owner

@forcar forcar Awaiting requested review from forcar forcar will be requested when the pull request is marked ready for review forcar is a code owner

@hauenst hauenst Awaiting requested review from hauenst hauenst will be requested when the pull request is marked ready for review hauenst is a code owner

@ajhobart ajhobart Awaiting requested review from ajhobart ajhobart will be requested when the pull request is marked ready for review ajhobart is a code owner

@mpaolone mpaolone Awaiting requested review from mpaolone mpaolone will be requested when the pull request is marked ready for review mpaolone is a code owner

@efuchey efuchey Awaiting requested review from efuchey efuchey will be requested when the pull request is marked ready for review efuchey is a code owner

@whit2333 whit2333 Awaiting requested review from whit2333 whit2333 will be requested when the pull request is marked ready for review whit2333 is a code owner

@ftouchte ftouchte Awaiting requested review from ftouchte ftouchte will be requested when the pull request is marked ready for review ftouchte is a code owner

@heddle heddle Awaiting requested review from heddle heddle will be requested when the pull request is marked ready for review heddle is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

gemc

Projects

None yet

Milestone

Real Run Number Simulations

Development

Successfully merging this pull request may close these issues.

3 participants

@baltzell @raffaelladevita