remove uikit target in favor of ios
#2545
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Nov 3, 2025
Member
There was a problem hiding this comment.
Please align file-naming. It should be *.ios.kt now (on AOSP it's enforced by tooling)
|
|
||
| companion object { | ||
|
|
||
| const val DEFAULT = "DEFAULT" |
Member
There was a problem hiding this comment.
What's default actually means here?
| tasks.register("testUIKit") { | ||
| val suffix = if (System.getProperty("os.arch") == "aarch64") "SimArm64Test" else "X64Test" | ||
| val uikitTestSubtaskName = "uikit$suffix" | ||
| tasks.register("testIos") { |
Member
There was a problem hiding this comment.
Probably requires CI update to correctly run tests
| ComposeComponent( | ||
| ":compose:ui:ui-uikit", | ||
| supportedPlatforms = ComposePlatforms.UI_KIT | ||
| supportedPlatforms = ComposePlatforms.IOS |
Member
There was a problem hiding this comment.
Is it compatiable change? Will transitive dependencies pickup new name?
Collaborator
There was a problem hiding this comment.
Theoretically it should be compatible as Gradle only looks for the target type, not name. But we should check that.
@shishkin-pavel, we should check if it is compatible on:
- the wizard project
- the wizard project + a library which has ios target with
-ios*suffix - the wizard project + a library which has ios target with
-uikit*suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify build by unifying targets
Testing
snapshot build
Release Notes
N/A