-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Can resolve methods in nested classes #2972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0a14fa0 to
94e5e04
Compare
|
Rebased onto 251. |
|
@EliseevEgor @BartvHelvert This has been untouched for three months now. May I ask for an update? |
|
@chbndrhnns thanks a lot for your contribution! Some of your changes are not covered by the new tests. Could you please add new tests to cover them? |
python/python-core-impl/src/com/jetbrains/python/extensions/QualifiedNameExt.kt
Show resolved
Hide resolved
python/python-core-impl/src/com/jetbrains/python/extensions/QualifiedNameExt.kt
Outdated
Show resolved
Hide resolved
python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyClassImpl.java
Outdated
Show resolved
Hide resolved
94e5e04 to
f0ca832
Compare
|
I updated the PR. |
Originally implemented by chbndrhnns in #2972 Co-authored-by: chbndrhnns <[email protected]> GitOrigin-RevId: 9c77edd1e868ad0120f2f3f0d618940388619f00
|
@chbndrhnns Thank you! |
Fixes https://youtrack.jetbrains.com/issue/PY-71963/Jump-to-source-from-test-panel-fails-when-using-nested-classes
Note
Enables resolving nested classes and their methods during qualified name lookup and adds tests covering inner/nested class scenarios in PyTestsLocator.
QualifiedNameExt.kt):QualifiedName.getElementAndResolvableNameto resolve nestedPyClasshierarchies and locate methods within nested classes (including multi-level nesting), with fallback to current class method lookup.PyTestsLocatorTestcovering:test_.Test.test_1).test.TestOuter.TestInner)....TestInner.test_1).Written by Cursor Bugbot for commit f0ca832. This will update automatically on new commits. Configure here.