[platform] Refactor: Replace repeated regex string literals with comp… #3272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilkrzywanski
force-pushed
the
refactor_pattern
branch
4 times, most recently
from
1d84677 to
b4aefe0
Compare
…iled Patterns and improve version comparisons
kamilkrzywanski
force-pushed
the
refactor_pattern
branch
from
b4aefe0 to
bd8d5f8
Compare
Member
|
Hi, sorry for the late reply, it is hard to say for me whether everything is correct. Could you maybe split the PR into smaller parts so we can merge and review them as separate changes? |
Contributor
Author
|
@BartvHelvert #3299 Part 1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[platform] Refactor: Replace repeated regex string literals with compiled Patterns and improve version comparisons
DBE-24432 Refactor: Replace repeated regex string literals with compiled Patterns and improve version comparisons issue by accident created in datagrip