[JEWEL-1061] Fix split button chevron getting squashed #3283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faogustavo
approved these changes
Oct 22, 2025
Collaborator
Author
|
(I'll rebase to get the Metalava fixes when I get the second review) |
This fixes an issue with the secondary content (the chevron) getting squashed in split buttons, when there isn't enough space to show both the primary and secondary contents fully. As a bonus, this also fixes: * The divider height is no longer capped, but scales correctly with the button's height * Colours were all sorts of wrong in standalone mode for buttons, especially in the disabled state (they are fine in bridge mode) * The semantics role of the secondary action is now the same as in Swing (button) * The modifier passed to split buttons is now applied in the right place, and the internal layout is simplified The buttons showcase is also improved, now showing a space- constrained split button that did not use to work correctly, and putting all the content in flow rows so it scales better as the window is resized. The visual appearance is also tweaked to better represent the information hierarchy.
rock3r
force-pushed
the
sebp/JEWEL-1061_fix-split-button-chevron
branch
from
99556ed to
922205c
Compare
daaria-s
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the secondary content (the chevron) getting squashed in split buttons, when there isn't enough space to show both the primary and secondary contents fully.
As a bonus, this also fixes:
The buttons showcase is also improved, now showing a space-constrained split button that did not use to work correctly, and putting all the content in flow rows so it scales better as the window is resized. The visual appearance is also tweaked to better represent the information hierarchy.
Screen.Recording.2025-10-17.at.19.20.41.mov
Before
After
Release notes
Bug fixes
*SplitButtons where the chevron would get squashed if the button wasn't wide enough to fit both the main and secondary content*SplitButtons where the divider height was limited, and would not grow with the button's height if it gets taller than the minimum height*Buttoncolours in standalone, especially in the disabled state, to realign them with Swing*SplitButtons to be the same as in Swing*SplitButtons being applied to the wrong level, causing all sorts of unexpected behaviour (e.g., if you set a height, the button's visual height would not grow)