[JEWEL-1067] Markdown: improve scrolling behavior #3287
+67
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVanGogen
force-pushed
the
alexvangogen/JEWEL-1067-better-scroll-sync
branch
from
8835b04 to
f9f25a6
Compare
rock3r
approved these changes
Oct 29, 2025
...arkdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/scrolling/ScrollingSynchronizer.kt
Show resolved
Hide resolved
1. Ensured scrolling always succeeds. ScrollingSynchronizer API is changed to support this contract. In IJ, scrolling events are sent frequently, so the Markdown preview picks only last ones within a certain timeframe. If `scrollToLine` fails (because the target block is unsupported, for example), then the scrolling stops abruptly. 2. Ensured scrolling to the block on the first line works.
AlexVanGogen
force-pushed
the
alexvangogen/JEWEL-1067-better-scroll-sync
branch
from
f9f25a6 to
08ad2a1
Compare
faogustavo
approved these changes
Oct 29, 2025
Contributor
Author
|
@rock3r Release notes -- updated |
Collaborator
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensured scrolling always succeeds. ScrollingSynchronizer API is changed to support this contract. In IJ, scrolling events are sent frequently,
so the Markdown preview picks only last ones within a certain timeframe. If
scrollToLinefails (because the target block is unsupported, for example), then the scrolling stops abruptly.Ensured scrolling to the block on the first line works.
Before:
Screen.Recording.2025-10-23.at.18.58.51.mov
After:
Screen.Recording.2025-10-23.at.19.56.34.mov
Release notes
Bug fixes
Deprecated API
ScrollingSynchronizer#scrollToLineis now marked as non-extendable (@ApiStatus.NonExtendable), in favor of new methodsScrollingSynchronizer#scrollToCoordinateandScrollingSynchronizer#findYCoordinateToScroll(#3287)