Conversation
Float identities (e.g. -Inf for max, +Inf for min) were encoded as raw bit patterns via plain varint, but the bytecode format expects ap_int encoding (zigzag + varint). This caused the disassembler to show NaN instead of -Inf for maximum, and 1.5 instead of +Inf for minimum. Fix: use encode_signed_varint! with Int128-widened bits so the zigzag shift-left never overflows. Integer identities had a separate bug: they were zigzag-encoded, but the format stores them as raw values (no zigzag). The existing zigzag also had a UInt32 overflow on the shift-left for typemin(Int32). Fix: remove zigzag from integer identities entirely and widen to UInt128 for the varint encoder. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Float identities (e.g. -Inf for max, +Inf for min) were encoded as raw bit patterns via plain varint, but the bytecode format expects ap_int encoding (zigzag + varint). This caused the disassembler to show NaN instead of -Inf for maximum, and 1.5 instead of +Inf for minimum.
Fix: use encode_signed_varint! with Int128-widened bits so the zigzag shift-left never overflows.
Integer identities had a separate bug: they were zigzag-encoded, but the format stores them as raw values (no zigzag). The existing zigzag also had a UInt32 overflow on the shift-left for typemin(Int32). Fix: remove zigzag from integer identities entirely and widen to UInt128 for the varint encoder.