Skip to content

Conversation

@andrearanica
Copy link
Contributor

Closes #12

@andrearanica
Copy link
Contributor Author

For the moment I added the automatic load of the quirks depending on the platform, and some buttons with which you can choose the platform variations to run the rom (each variation can change the quirks). Let me know if there is something more

@JustDoom
Copy link
Owner

Awesome. I will review this once I have time again

@JustDoom JustDoom self-requested a review September 16, 2025 00:32

CLAY_TEXT(CLAY_STRING("Settings"), CLAY_TEXT_CONFIG({ .textColor = {0, 0, 0, 255}, .fontSize = 24 }));

if (this->selectedPlatformId == nullptr || std::find(programPlatforms.begin(), programPlatforms.end(), *this->selectedPlatformId) == programPlatforms.end()) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why but there is a seg fault from this line. Wll upload a video soon

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to test whether clicking the platform on one rom would change the settings on another rom. Because it should not affect the others and only the rom it is for. But when I was trying this kept happening

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025-09-16.10-53-54.mp4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it was due to this row

this->selectedPlatformId = &programPlatforms.at(0);

I replaced it with this row and it looks like it's resolved.

this->selectedPlatformId = new std::string(programPlatforms.at(0));

Let me know if you notice this again.

@JustDoom
Copy link
Owner

Sorry I have been very busy 😭
I will get to this hopefully on the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the Chip8 database for help running ROMs

2 participants