Conversation
- Changed IndentPPDirectives setting in .clang-format to 'AfterHash'. - Enhanced header inclusion logic in expected.hpp to check for <version> or <experimental/version> before including <expected>. - Cleaned up conditional compilation directives for better readability and maintainability.
Katze719
force-pushed
the
36-missing-include-versionh
branch
from
13af793 to
7646019
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves header detection for <expected> by checking for the <version> header presence before including it, updates .clang-format for clearer preprocessor indentation, and refactors the expected.hpp implementation.
- Added
<version>header detection using__has_includeto ensure feature test macros are available - Reordered conditional compilation to check
__cpp_lib_expectedbefore C++ version macros - Removed empty user-defined constructors/destructors from union types and reordered class members
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| include/threadschedule/expected.hpp | Adds <version> header detection, improves feature test macro checking order, applies consistent preprocessor indentation, removes empty union constructors, and reorders class members |
| CHANGELOG.md | Documents the changes for v1.2.3 release including build/style updates, header detection improvements, and refactoring |
| .clang-format | Updates IndentPPDirectives from None to AfterHash for clearer preprocessor nesting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…t and expected.hpp header logic
Katze719
force-pushed
the
36-missing-include-versionh
branch
from
7646019 to
e3fed1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.