Skip to content

feat: add OneKey desktop channel flow#6905

Draft
wabicai wants to merge 4 commits intoKeeperCommunity:mainfrom
wabicai:feat/onekey-desktop-channel
Draft

feat: add OneKey desktop channel flow#6905
wabicai wants to merge 4 commits intoKeeperCommunity:mainfrom
wabicai:feat/onekey-desktop-channel

Conversation

@wabicai
Copy link

@wabicai wabicai commented Feb 24, 2026

Background

This PR enables OneKey in Bitcoin Keeper via desktop channel while aligning behavior to the unified sidecar architecture:

bitcoin-keeper -> keeper-desktop -> HWI sidecar -> OneKey

What changed

  • Added OneKey into desktop-channel signer experience and related UI surfaces.
  • Updated OneKey branding assets and localized copy (English/Spanish).
  • Removed OneKey from miniscript signer eligibility in add-signer flow.
  • Removed OneKey vault registration entry in desktop-channel advanced settings.
  • Behavior is aligned to Trezor-style boundaries for this flow:
    • ✅ connect / verify-address / signing
    • ❌ register multisig / vault registration

OneKey PIN behavior alignment (classic vs pro)

This app now follows keeper-desktop/HWI model-specific unlock behavior:

  • classic / classic1s / classicpure -> host PIN matrix (promptpin + sendpin).
  • pro / touch -> PIN input on device screen only (desktop waits for unlock confirmation).

This avoids treating all OneKey models the same and keeps the UX aligned with actual hardware capabilities.

Dependency

Validation

  • Prettier applied to touched files.
  • Local ESLint in this environment still has pre-existing setup issue (jest/globals unknown), not introduced by this PR.

For real-device HWI-side validation commands and outputs, see HWI PR #826 (OneKey Pro tested on February 26, 2026), which includes:

  • enumerate/path discovery
  • xpub/getmasterxpub
  • getdescriptors/getkeypool
  • displayaddress (legacy/sh_wit/wit/tap)
  • signmessage
  • signtx (negative + positive)
  • error-path checks

Desktop/manual regression checklist to be run with this PR chain:

  • OneKey Classic/Classic1S/Classic Pure: verify host PIN modal flow and successful unlock.
  • OneKey Pro: verify on-device PIN unlock flow and successful continue.
  • End-to-end after unlock: connect -> shareXpubs -> signTx -> verifyAddress.

@wabicai wabicai marked this pull request as draft February 24, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant