Release v2.5.10#6920
Merged
cakesoft-vaibhav merged 17 commits intomainfrom Apr 14, 2026
Merged
Conversation
Show a toast error to user suggesting to remove invalid signer.
This error happens when adding a Satochip signer directly after importing a BIP39 seed via the 'Setup options'
Error message: ```SetupSatochip.tsx:226 Warning: TypeError: Cannot read property 'n' of undefined```
Root cause: ImportSatochipSeed used CommonActions.navigate("EnterSeedScreen"),
which pops back to an existing EnterSeedScreen already below AddSigningDevice
in the stack, ejecting AddSigningDevice and SetupSatochip. When
SatochipSeedImportModal later navigated back to SatochipAction it created a
fresh instance with no original params, so scheme.n was undefined → crash.
Additionally, setupSatochipParams was passed into SatochipSeedImportModal but
never forwarded to SatochipAction on close, losing isMultisig/accountNumber/
signer context needed for the subsequent NFC signing step.
Changes:
- ImportSatochipSeed: replace CommonActions.navigate → StackActions.push for
EnterSeedScreen so a new instance is always pushed, preserving AddSigningDevice
in the stack
- SatochipSeedImportModal: extract setupSatochipParams from route.params and
spread it into the SatochipAction return navigation so original SetupSatochip
params are fully restored after seed import
When card is not setup, authenticity cannot be evaluated.
Fix bug when adding a Satochip key directly after importing a BIP39 seed
Fix 6901 crash
Fix public key recovery from signature for edge case where most significant byte of pubkey x-coordinate is zero. See satochip-react-native patch here: Toporin/satochip-react-native@1076e7c Fixes #6914
Update satochip-react-native library to v0.1.4
…ndroid project files.
Update version to 2.5.10 and increment version code to 590
Release v2.5.10
cakesoft-vaibhav
requested review from
ben-kaufman,
cakesoft-shashank and
cakesoft-utkarsh
cakesoft-shashank
approved these changes
Apr 13, 2026
cakesoft-utkarsh
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.