Skip to content

Fix/#365 alarm entity 수정 #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2025
Merged

Fix/#365 alarm entity 수정 #366

merged 3 commits into from
Feb 19, 2025

Conversation

@tomatozil
Copy link
Collaborator

@tomatozil tomatozil commented Feb 19, 2025 •
edited
Loading

🔧 어떤 작업인가요?

이벤트 허브에서 쓰는 알림 엔티티의 타입이 DB와 불일치하여 변경했습니다.
Long -> String

#️⃣ 연관된 이슈

#365

💡 리뷰어에게 하고 싶은 말

그 외에 sse 구현을 마구 뽐내기 위해서는 알림 주기가 5000보다 작아야하므로 100으로 줄였습니다.
노션과 시크릿키도 업데이트 할게요!

🙏 아래 내용이 모두 충족 되었는지 확인해주세요 🙏

  • PR 이전 dev 브랜치 병합 하셨나요?
  • PR 이전 빌드 테스트 정상적으로 성공했나요?
  • PR 상세내용이 충분히 기재 되었나요?
  • PR 리뷰어, 할당자, 라벨, 프로젝트 확인

@tomatozil tomatozil linked an issue Feb 19, 2025 that may be closed by this pull request
[fix] alarm entity 수정 #365
Closed
1 task
kbyunghoon
kbyunghoon approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@kbyunghoon kbyunghoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@tomatozil tomatozil merged commit f8539b2 into develop Feb 19, 2025
@Suxxxxhyun Suxxxxhyun added the 🐛 Fix 버그 수정 label Feb 25, 2025
@tomatozil tomatozil deleted the fix/#365-alarm-entity-수정 branch February 27, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbyunghoon kbyunghoon kbyunghoon approved these changes

Assignees

No one assigned

Labels

🐛 Fix 버그 수정

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[fix] alarm entity 수정

4 participants

@tomatozil @kbyunghoon @Suxxxxhyun