fix: refresh worker container when REPO changes between runs#84
Closed
ChinmayShringi wants to merge 1 commit intoKeygraphHQ:mainfrom
Closed
fix: refresh worker container when REPO changes between runs#84ChinmayShringi wants to merge 1 commit intoKeygraphHQ:mainfrom
ChinmayShringi wants to merge 1 commit intoKeygraphHQ:mainfrom
Conversation
When users changed REPO= between runs, the old repository content persisted because the worker container wasn't recreated with the new volume mount. This adds the same refresh logic that already exists for OUTPUT_DIR to also handle TARGET_REPO changes. Uses --force-recreate to guarantee the container picks up the new mount. Fixes KeygraphHQ#70
ChinmayShringi
force-pushed
the
fix/repo-change-between-runs
branch
from
fc74603 to
f44b058
Compare
Collaborator
|
We've fixed this more comprehensively in #107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When users changed
REPO=between runs, the old repository content persisted because the worker container wasn't recreated with the new volume mount.Root Cause
In
ensure_containers(), if Temporal is already healthy, the function returns early without refreshing the worker container. The existing fix forOUTPUT_DIRwasn't applied toTARGET_REPO.Solution
Add the same worker refresh logic for
TARGET_REPOthat already exists forOUTPUT_DIR. Docker compose will only recreate the container if the mount actually changed.Changes
shannon: Added TARGET_REPO refresh logic (7 lines)Test plan
./shannon start URL=... REPO=/path/to/repo1./shannon start URL=... REPO=/path/to/repo2Fixes #70