feat: add changeset-based release notes mechanism #71
Conversation
![kiloconnect[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| - name: Setup Bun | ||
| uses: oven-sh/setup-bun@v2 | ||
| with: | ||
| bun-version: latest |
There was a problem hiding this comment.
WARNING: Non-deterministic Bun version (latest) can break the release workflow
Using bun-version: latest can introduce unexpected CI breakages when Bun releases. Pin to the repo's declared Bun version (e.g. the packageManager version) to keep releases reproducible.
| pull_request: | ||
| types: [closed] | ||
| # kilocode_change end | ||
| push: |
There was a problem hiding this comment.
SUGGESTION: Workflow triggers on push but the job is gated to PR-merge events
With the current job if, pushes to dev/snapshot-* will still start the workflow but skip jobs.publish. Consider either removing the push trigger (if releases should only come from the changeset bump PR) or expanding the job if to include the desired push cases to avoid no-op runs.
| ( github.event_name == 'pull_request' && | ||
| github.event.pull_request.merged == true && | ||
| github.event.pull_request.base.ref == 'dev' && | ||
| contains(github.event.pull_request.title, 'Changeset version bump') ) || |
There was a problem hiding this comment.
WARNING: Release trigger relies only on PR title substring
contains(github.event.pull_request.title, 'Changeset version bump') is fairly permissive; any merged PR to dev with that phrase in the title would satisfy this condition. To reduce accidental/undesired releases, consider also checking something that uniquely identifies the changesets bot PR (e.g. github.event.pull_request.user.login == 'github-actions[bot]' and/or matching head.ref, labels, or an expected PR branch naming convention).
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
SUGGESTION
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (5 files)
|
Summary
@changesets/cliintegration matching the kilocode repository pattern for release notes generation.changesetconfiguration with@changesets/changelog-githubfor GitHub-flavored changelogs (PR links, commit hashes, contributor attribution)changeset-release.ymlworkflow that creates/updates a "Changeset version bump" PR when changes are pushed todevpublish.ymlto trigger releases when the changeset version bump PR is mergedHow it works
bun run changesetto create changeset files describing their changesdev, the changeset-release workflow creates a "Changeset version bump" PR