Release consolidated chart as kong 3.0.0-rc1 #1105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy pieces of the ingress chart Konnect example into the kong chart Konnect example.
Add migration notes for the ingress to kong 3.x change. Remove separate ingress templates and such.
Co-authored-by: Michał Flendrich <[email protected]>
rainest
changed the title
randmonkey
reviewed
Jul 17, 2024
Contributor
randmonkey
left a comment
randmonkey
left a comment
There was a problem hiding this comment.
Generally looks good, some minor comments.
randmonkey
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Releases the consolidated chart as kong 3.0.0-rc1.
Removes most existing
ingresschart content and consolidates someingressdocumentation into thekongfiles. Leaves a brief migration message and historical underingress.This will release an RC chart version from the release branch.
mainwill remain as-is for now. When we are ready to finalize the release, we will cut an old version release branch from the tip ofmainbefore merging this intomain.Special notes for your reviewer:
Clone of #976 to no longer ping Michał.
https://helm.sh/docs/chart_template_guide/helm_ignore_file/ provides more tooling if we need to persist
ingressin some fashion re chartsnap and whatnot, but AFAICT we don't need it for consolidation so long as the chartsnap config is gone andcharts/ingressjust holds the old changelog/readme. It's available if some other Helm tool wants to do something with the old dir.