fix(ai-proxy): OpenAI chat completion's tool_choice was not converted to Anthropic's #14694
+211
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to Anthropic's Signed-off-by: Zexuan Luo <[email protected]>
Contributor
Author
|
@HarrievG |
chronolaw
added
the
cherry-pick kong-ee
chronolaw
reviewed
Aug 4, 2025
| return {type = "any"} | ||
| elseif openai_tool_choice == "none" or openai_tool_choice == "auto" then | ||
| return {type = openai_tool_choice} | ||
| else |
Contributor
There was a problem hiding this comment.
Let's add a blank line before else, see https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#conditional-expressions
fffonion
approved these changes
Sep 22, 2025
fffonion
removed
the
cherry-pick kong-ee
Contributor
|
I'm removing the cherry-pick ee label as it's manually cherrypicked. |
dylankyc
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #14690