Set Default Behavior to Stop Training Upon Convergence#16
Merged
michaelmckinsey1 merged 11 commits intoLBANN:mainfrom Feb 19, 2026
Merged
Set Default Behavior to Stop Training Upon Convergence#16michaelmckinsey1 merged 11 commits intoLBANN:mainfrom
michaelmckinsey1 merged 11 commits intoLBANN:mainfrom
Conversation
michaelmckinsey1
changed the title
PatrickRMiles
requested changes
Feb 19, 2026
ScaFFold/utils/trainer.py
Outdated
| f"val_score of {val_score} is > threshold of 0.95. Benchmark run complete. Wrapping up..." | ||
| ) | ||
| return 0 | ||
| dice_score_train = dice_sum |
Collaborator
There was a problem hiding this comment.
I think we should actually use val_score here in place of dice_sum. dice_sum is the per-batch dice score, whereas val_score is averaged over all batches in an epoch. So just replace this line with dice_score_train = val_score and then this PR is good to go.
PatrickRMiles
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.95) instead of training for a certain number of epochs.