Conversation
|
There are some breaking changes between RabbitMQ 3 and 4; see https://www.rabbitmq.com/docs/whats-new - hence adding it as a new commodity. |
|
No need for 2.0/3.7 compose fragments as next devenv version will not support them |
Fix autoupdate
scripts/docker/rabbitmq-4/Dockerfile
Outdated
| @@ -0,0 +1,20 @@ | |||
| # This is so a reset (dc down) won't remove the base rabbit image, only the one created from this dockerfile | |||
| FROM docker.io/rabbitmq:4-management | |||
There was a problem hiding this comment.
I think although postgres treats minor versions as patches, rabbit may treat them as actual feature releases, so our externally managed versions may get left behind by local?
There was a problem hiding this comment.
Would a fix to 4.2 be okay? I'd also like to avoid going the opposite way and having a version that's too far behind locally.
There was a problem hiding this comment.
Might be worth checking with w****s that 4.2 is correct
There was a problem hiding this comment.
4.2 is fine according to w****s
What kind of change does this PR introduce (Bug fix, feature, docs update, ...)?
Feature
What is the current behavior?
RabbitMQ 3 is supported as a commodity, however RabbitMQ 4 is not
What is the new behavior (if this is a feature change)?
RabbitMQ 4 is available as a commodity.
Does this PR introduce a breaking change? If so, what actions will users need to take in order to regain compatibility?
No
Checklists
All submissions
developbranch, and the branch rebased with commits squashed if needed?New feature and bug fix submissions